Lint Report

Overview

	Correctness
1	MissingPermission: Missing Permissions
3	ApplySharedPref: Use `apply()` on `SharedPreferences`
3	DefaultLocale: Implied default locale in case conversion
2	OldTargetApi: Target SDK attribute is not targeting latest version
1	SimpleDateFormat: Implied locale in date format
1	UnusedAttribute: Attribute unused on older versions
4	AppCompatCustomView: Appcompat Custom Widgets
1	GradleDependency: Obsolete Gradle Dependency
5	GradleDynamicVersion: Gradle Dynamic Version
4	GradleOverrides: Value overridden by Gradle build script
2	RestrictedApi: Restricted API
	Security
2	HardwareIds: Hardware Id Usage
1	AllowBackup: AllowBackup/FullBackupContent Problems
	Performance
1	WakelockTimeout: Using wakeLock without timeout
2	ObsoleteSdkInt: Obsolete SDK_INT Version Check
3	StaticFieldLeak: Static Field Leaks
22	UnusedResources: Unused resources
	Usability:Icons
1	IconDipSize: Icon density-independent size validation
1	IconDuplicatesConfig: Identical bitmaps across various configurations
1	IconLocation: Image defined in density-independent drawable folder
3	IconDensities: Icon densities validation
	Usability
1	GoogleAppIndexingWarning: Missing support for Firebase App Indexing
12	ViewConstructor: Missing View constructors for XML inflation
	Accessibility
1	ClickableViewAccessibility: Accessibility in Custom Views
	Disabled Checks (32)

Missing Permissions

../../src/org/muctec/smartfritz/Controls.java:2421: Missing permissions required by TelephonyManager.getDeviceId: android.permission.READ_PRIVILEGED_PHONE_STATE

 2418   TelephonyManager telephony = (TelephonyManager) activity.getSystemService(Context.TELEPHONY_SERVICE);
 2419     if (telephony!=null) {
 2420         try {
 2421             f = telephony.getDeviceId();                                                                     
 2422         } catch (SecurityException ex) {
 2423             Log.e("getDevDeviceID", ex.getMessage());
 2424         }

MissingPermission Correctness Error Priority 9/10

Use apply() on SharedPreferences

../../src/org/muctec/smartfritz/jPreferences.java:62: Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background

  59         
  60         if( edt != null ){
  61          edt.putInt(_key, _value);
  62          edt.commit();                                                                                    
  63         }
  64     }

../../src/org/muctec/smartfritz/jPreferences.java:83: Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background

  80         
  81         if( edt != null ){
  82          edt.putString(_key, _value);
  83          edt.commit();                                                                                    
  84         }
  85     }

../../src/org/muctec/smartfritz/jPreferences.java:103: Consider using apply() instead; commit writes its data to persistent storage immediately, whereas apply will handle it in the background

 100         
 101         if( edt != null ){
 102          edt.putBoolean(_key, _value);
 103          edt.commit();                                                                                    
 104         }
 105     }
 106 }

Consider using apply() instead of commit on shared preferences. Whereas commit blocks and writes its data to persistent storage immediately, apply will handle it in the background.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "ApplySharedPref" as explained in the Suppressing Warnings and Errors section.

ApplySharedPref Correctness Warning Priority 6/10

Implied default locale in case conversion

../../src/org/muctec/smartfritz/Controls.java:1525: Implicitly using the default locale is a common source of bugs: Use toUpperCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault().

 1522                         if (isIPv4) return r = inetAddress.getHostAddress();
 1523                         if (!isIPv4) {
 1524                             int delim = inetAddress.getHostAddress().indexOf('%'); // drop ip6 zone suffix
 1525                             r = delim < 0 ? inetAddress.getHostAddress().toUpperCase() : inetAddress.getHostAddress().substring(0, delim).toUpperCase();
 1526                         }
 1527                     }
 1528                 }

 1522                         if (isIPv4) return r = inetAddress.getHostAddress();
 1523                         if (!isIPv4) {
 1524                             int delim = inetAddress.getHostAddress().indexOf('%'); // drop ip6 zone suffix
 1525                             r = delim < 0 ? inetAddress.getHostAddress().toUpperCase() : inetAddress.getHostAddress().substring(0, delim).toUpperCase();
 1526                         }
 1527                     }
 1528                 }

../../src/org/muctec/smartfritz/Controls.java:1543: Implicitly using the default locale is a common source of bugs: Use String.format(Locale, ...) instead

 1540 
 1541         //String ip = Formatter.formatIpAddress(
 1542         int ipAddress = mWifi.getConnectionInfo().getIpAddress();
 1543         String sIP = String.format("%d.%d.%d.%d",                                                         
 1544                 (ipAddress & 0xff),
 1545                 (ipAddress >> 8 & 0xff),
 1546                 (ipAddress >> 16 & 0xff),

Calling String#toLowerCase() or #toUpperCase() without specifying an explicit locale is a common source of bugs. The reason for that is that those methods will use the current locale on the user's device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for i is not I.

If you want the methods to just perform ASCII replacement, for example to convert an enum name, call String#toUpperCase(Locale.US) instead. If you really want to use the current locale, call String#toUpperCase(Locale.getDefault()) instead.

More info: http://developer.android.com/reference/java/util/Locale.html#default_locale

To suppress this error, use the issue id "DefaultLocale" as explained in the Suppressing Warnings and Errors section.

DefaultLocale Correctness Warning Priority 6/10

Target SDK attribute is not targeting latest version

../../AndroidManifest.xml:3: Not targeting the latest versions of Android; compatibility modes apply. Consider testing and updating this version. Consult the android.os.Build.VERSION_CODES javadoc for details.

  1 <?xml version="1.0" encoding="UTF-8"?>
  2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.muctec.smartfritz" android:versionCode="1" android:versionName="1.0">
  3   <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="28"/>                              
  4   <uses-permission android:name="android.permission.ACCESS_BLUETOOTH_SHARE"/>
  5   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
  6   <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

../../build.gradle:34: Not targeting the latest versions of Android; compatibility modes apply. Consider testing and updating this version. Consult the android.os.Build.VERSION_CODES javadoc for details.

 31     compileSdkVersion 28
 32     defaultConfig {
 33             minSdkVersion 14
 34             targetSdkVersion 28                                                                     
 35             versionCode 1
 36             versionName "1.0"
 37     }

When your application runs on a version of Android that is more recent than your targetSdkVersion specifies that it has been tested with, various compatibility modes kick in. This ensures that your application continues to work, but it may look out of place. For example, if the targetSdkVersion is less than 14, your app may get an option button in the UI.

To fix this issue, set the targetSdkVersion to the highest available value. Then test your app to make sure everything works correctly. You may want to consult the compatibility notes to see what changes apply to each version you are adding support for: http://developer.android.com/reference/android/os/Build.VERSION_CODES.html as well as follow this guide:
https://developer.android.com/distribute/best-practices/develop/target-sdk.html

More info:

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "OldTargetApi" as explained in the Suppressing Warnings and Errors section.

OldTargetApi Correctness Warning Priority 6/10

Implied locale in date format

../../src/org/muctec/smartfritz/Controls.java:638: To get local formatting use getDateInstance(), getDateTimeInstance(), or getTimeInstance(), or use new SimpleDateFormat(String template, Locale locale) with for example Locale.US for ASCII dates.

  635 
  636     //by TR3E
  637     public String GetTimeHHssSS( long millisTime ) {
  638           SimpleDateFormat formatter = new SimpleDateFormat ( "mm:ss:SS" );                               
  639           return( formatter.format ( new Date (millisTime) ) );    
  640     }

Almost all callers should use getDateInstance(), getDateTimeInstance(), or getTimeInstance() to get a ready-made instance of SimpleDateFormat suitable for the user's locale. The main reason you'd create an instance this class directly is because you need to format/parse a specific machine-readable format, in which case you almost certainly want to explicitly ask for US to ensure that you get ASCII digits (rather than, say, Arabic digits).

Therefore, you should either use the form of the SimpleDateFormat constructor where you pass in an explicit locale, such as Locale.US, or use one of the get instance methods, or suppress this error if really know what you are doing.

More info: http://developer.android.com/reference/java/text/SimpleDateFormat.html

To suppress this error, use the issue id "SimpleDateFormat" as explained in the Suppressing Warnings and Errors section.

SimpleDateFormat Correctness Warning Priority 6/10

Attribute unused on older versions

../../AndroidManifest.xml:39: Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 14)

 36   <uses-feature android:name="android.hardware.sensor.stepcounter" android:required="false"/>
 37   <uses-feature android:name="android.hardware.sensor.stepdetector" android:required="false"/>
 38   <supports-screens android:smallScreens="true" android:normalScreens="true" android:largeScreens="true" android:anyDensity="true"/>
 39   <application android:allowBackup="true" android:icon="@drawable/ic_launcher" android:label="@string/app_name" android:theme="@style/AppTheme" android:networkSecurityConfig="@xml/network_security_config">
 40     <activity android:name="org.muctec.smartfritz.App" android:label="@string/app_name" android:configChanges="orientation|keyboardHidden|screenSize|screenLayout|fontScale" android:launchMode="standard" android:enabled="true">
 41       <intent-filter>
 42         <action android:name="android.intent.action.MAIN"/>

This check finds attributes set in XML files that were introduced in a version newer than the oldest version targeted by your application (with the minSdkVersion attribute).

This is not an error; the application will simply ignore the attribute. However, if the attribute is important to the appearance or functionality of your application, you should consider finding an alternative way to achieve the same result with only available attributes, and then you can optionally create a copy of the layout in a layout-vNN folder which will be used on API NN or higher where you can take advantage of the newer attribute.

Note: This check does not only apply to attributes. For example, some tags can be unused too, such as the new <tag> element in layouts introduced in API 21.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnusedAttribute" as explained in the Suppressing Warnings and Errors section.

UnusedAttribute Correctness Warning Priority 6/10

Appcompat Custom Widgets

../../src/org/muctec/smartfritz/jButton.java:24: This custom view should extend android.support.v7.widget.AppCompatButton instead

  21 import android.view.ViewGroup;
  22 import android.widget.Button;
  23 
  24 public class jButton extends Button {                                                               
  25 
  26     private Controls controls = null;   // Control Class for Event
  27     private jCommons LAMWCommon;

../../src/org/muctec/smartfritz/jCheckBox.java:13: This custom view should extend android.support.v7.widget.AppCompatCheckBox instead

  10 import android.widget.CheckBox;
  11 import android.view.Gravity;
  12 
  13 public class jCheckBox extends CheckBox {                                                           
  14     //Java-Pascal Interface
  15     private long             PasObj   = 0;      // Pascal Obj
  16     private Controls        controls = null;   // Control Class for Event

../../src/org/muctec/smartfritz/jEditText.java:42: This custom view should extend android.support.v7.widget.AppCompatEditText instead

  39 
  40 //Reviewed by TR3E on 08/20/2019
  41 
  42 public class jEditText extends EditText {                                                           
  43     //Pascal Interface
  44     //private long           PasObj   = 0;      // Pascal Obj
  45     private Controls      controls = null;   // Control Class for Event

../../src/org/muctec/smartfritz/jTextView.java:37: This custom view should extend android.support.v7.widget.AppCompatTextView instead

  34 import android.view.Gravity;
  35 import android.widget.TextView;
  36 
  37 public class jTextView extends TextView {                                                           
  38     //Java-Pascal Interface
  39     private Controls        controls = null;   // Control Class for Event
  40     private jCommons LAMWCommon;

In order to support features such as tinting, the appcompat library will automatically load special appcompat replacements for the builtin widgets. However, this does not work for your own custom views.

Instead of extending the android.widget classes directly, you should instead extend one of the delegate classes in android.support.v7.widget.AppCompat.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "AppCompatCustomView" as explained in the Suppressing Warnings and Errors section.

AppCompatCustomView Correctness Error Priority 4/10

Obsolete Gradle Dependency

../../build.gradle:8: A newer version of com.android.tools.build:gradle than 3.4.1 is available: 4.0.1

  5         google()
  6     }
  7     dependencies {
  8         classpath 'com.android.tools.build:gradle:3.4.1'                                            
  9     }
 10 }
 11 allprojects {

GradleDependency Correctness Warning Priority 4/10

Gradle Dynamic Version

../../build.gradle:56: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:support-v4:28.+)

 53 }
 54 dependencies {
 55     implementation fileTree(include: ['*.jar'], dir: 'libs')
 56     implementation 'com.android.support:support-v4:28.+'                                            
 57     implementation 'com.android.support:appcompat-v7:28.+'
 58     implementation 'com.android.support:design:28.+'
 59     implementation 'com.android.support:cardview-v7:28.+'

../../build.gradle:57: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:appcompat-v7:28.+)

 54 dependencies {
 55     implementation fileTree(include: ['*.jar'], dir: 'libs')
 56     implementation 'com.android.support:support-v4:28.+'
 57     implementation 'com.android.support:appcompat-v7:28.+'                                          
 58     implementation 'com.android.support:design:28.+'
 59     implementation 'com.android.support:cardview-v7:28.+'
 60     implementation 'com.android.support:recyclerview-v7:28.+'

../../build.gradle:58: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:design:28.+)

 55     implementation fileTree(include: ['*.jar'], dir: 'libs')
 56     implementation 'com.android.support:support-v4:28.+'
 57     implementation 'com.android.support:appcompat-v7:28.+'
 58     implementation 'com.android.support:design:28.+'                                                
 59     implementation 'com.android.support:cardview-v7:28.+'
 60     implementation 'com.android.support:recyclerview-v7:28.+'
 61 }

../../build.gradle:59: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:cardview-v7:28.+)

 56     implementation 'com.android.support:support-v4:28.+'
 57     implementation 'com.android.support:appcompat-v7:28.+'
 58     implementation 'com.android.support:design:28.+'
 59     implementation 'com.android.support:cardview-v7:28.+'                                           
 60     implementation 'com.android.support:recyclerview-v7:28.+'
 61 }
 62

../../build.gradle:60: Avoid using + in version numbers; can lead to unpredictable and unrepeatable builds (com.android.support:recyclerview-v7:28.+)

 57     implementation 'com.android.support:appcompat-v7:28.+'
 58     implementation 'com.android.support:design:28.+'
 59     implementation 'com.android.support:cardview-v7:28.+'
 60     implementation 'com.android.support:recyclerview-v7:28.+'                                       
 61 }
 62  
 63 task run(type: Exec, dependsOn: ':installDebug') {

Using + in dependencies lets you automatically pick up the latest available version rather than a specific, named version. However, this is not recommended; your builds are not repeatable; you may have tested with a slightly different version than what the build server used. (Using a dynamic version as the major version number is more problematic than using it in the minor version position.)
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "GradleDynamicVersion" as explained in the Suppressing Warnings and Errors section.

GradleDynamicVersion Correctness Warning Priority 4/10

Value overridden by Gradle build script

../../AndroidManifest.xml:2: This versionCode value (1) is not used; it is always overridden by the value specified in the Gradle build script (1)

  1 <?xml version="1.0" encoding="UTF-8"?>
  2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.muctec.smartfritz" android:versionCode="1" android:versionName="1.0">
  3   <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="28"/>
  4   <uses-permission android:name="android.permission.ACCESS_BLUETOOTH_SHARE"/>
  5   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>

../../AndroidManifest.xml:2: This versionName value (1.0) is not used; it is always overridden by the value specified in the Gradle build script (1.0)

  1 <?xml version="1.0" encoding="UTF-8"?>
  2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.muctec.smartfritz" android:versionCode="1" android:versionName="1.0">
  3   <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="28"/>
  4   <uses-permission android:name="android.permission.ACCESS_BLUETOOTH_SHARE"/>
  5   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>

../../AndroidManifest.xml:3: This minSdkVersion value (14) is not used; it is always overridden by the value specified in the Gradle build script (14)

  1 <?xml version="1.0" encoding="UTF-8"?>
  2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.muctec.smartfritz" android:versionCode="1" android:versionName="1.0">
  3   <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="28"/>                              
  4   <uses-permission android:name="android.permission.ACCESS_BLUETOOTH_SHARE"/>
  5   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
  6   <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

../../AndroidManifest.xml:3: This targetSdkVersion value (28) is not used; it is always overridden by the value specified in the Gradle build script (28)

  1 <?xml version="1.0" encoding="UTF-8"?>
  2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.muctec.smartfritz" android:versionCode="1" android:versionName="1.0">
  3   <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="28"/>                              
  4   <uses-permission android:name="android.permission.ACCESS_BLUETOOTH_SHARE"/>
  5   <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
  6   <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

The value of (for example) minSdkVersion is only used if it is not specified in the build.gradle build scripts. When specified in the Gradle build scripts, the manifest value is ignored and can be misleading, so should be removed to avoid ambiguity.
To suppress this error, use the issue id "GradleOverrides" as explained in the Suppressing Warnings and Errors section.

GradleOverrides Correctness Warning Priority 4/10

Restricted API

../../src/org/muctec/smartfritz/jsFloatingButton.java:116: VisibilityAwareImageButton.setVisibility can only be called from within the same library group (groupId=com.android.support)

 113   //GUIDELINE: please, preferentially, init all yours params names with "_", ex: int _flag, String _hello ...
 114   
 115   public void SetVisibility(int _value) {  //       
 116   this.setVisibility(_value);   //View.GONE=8   View.VISIBLE=0  View.INVISIBLE=4                   
 117   }
 118   
 119   public void SetCompatElevation(float _value){

../../src/org/muctec/smartfritz/jsFloatingButton.java:207: VisibilityAwareImageButton.setVisibility can only be called from within the same library group (groupId=com.android.support)

 204                    parent.invalidate();    
 205                }
 206         }        
 207         this.setVisibility(android.view.View.VISIBLE);                                                    
 208    }
 209 }

This API has been flagged with a restriction that has not been met.

Examples of API restrictions:
* Method can only be invoked by a subclass
* Method can only be accessed from within the same library (defined by the Gradle library group id)
* Method can only be accessed from tests.

You can add your own API restrictions with the @RestrictTo annotation.
To suppress this error, use the issue id "RestrictedApi" as explained in the Suppressing Warnings and Errors section.

RestrictedApi Correctness Error Priority 4/10

Hardware Id Usage

../../src/org/muctec/smartfritz/Controls.java:2406: Using getLine1Number to get device identifiers is not recommended.

 2403   TelephonyManager telephony = (TelephonyManager) activity.getSystemService(Context.TELEPHONY_SERVICE);
 2404   if (telephony!=null) {
 2405       try {
 2406           f = telephony.getLine1Number();                                                                 
 2407       } catch (SecurityException ex) {
 2408           Log.e("getDevPhoneNumber", ex.getMessage());
 2409       }

../../src/org/muctec/smartfritz/Controls.java:2421: Using getDeviceId to get device identifiers is not recommended.

 2418   TelephonyManager telephony = (TelephonyManager) activity.getSystemService(Context.TELEPHONY_SERVICE);
 2419     if (telephony!=null) {
 2420         try {
 2421             f = telephony.getDeviceId();                                                                     
 2422         } catch (SecurityException ex) {
 2423             Log.e("getDevDeviceID", ex.getMessage());
 2424         }

Using these device identifiers is not recommended other than for high value fraud prevention and advanced telephony use-cases. For advertising use-cases, use AdvertisingIdClient$Info#getId and for analytics, use InstanceId#getId.

More info: https://developer.android.com/training/articles/user-data-ids.html

To suppress this error, use the issue id "HardwareIds" as explained in the Suppressing Warnings and Errors section.

HardwareIds Security Warning Priority 6/10

AllowBackup/FullBackupContent Problems

../../AndroidManifest.xml:39: On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html

 36   <uses-feature android:name="android.hardware.sensor.stepcounter" android:required="false"/>
 37   <uses-feature android:name="android.hardware.sensor.stepdetector" android:required="false"/>
 38   <supports-screens android:smallScreens="true" android:normalScreens="true" android:largeScreens="true" android:anyDensity="true"/>
 39   <application android:allowBackup="true" android:icon="@drawable/ic_launcher" android:label="@string/app_name" android:theme="@style/AppTheme" android:networkSecurityConfig="@xml/network_security_config">
 40     <activity android:name="org.muctec.smartfritz.App" android:label="@string/app_name" android:configChanges="orientation|keyboardHidden|screenSize|screenLayout|fontScale" android:launchMode="standard" android:enabled="true">
 41       <intent-filter>
 42         <action android:name="android.intent.action.MAIN"/>

The allowBackup attribute determines if an application's data can be backed up and restored. It is documented at http://developer.android.com/reference/android/R.attr.html#allowBackup

By default, this flag is set to true. When this flag is set to true, application data can be backed up and restored by the user using adb backup and adb restore.

This may have security consequences for an application. adb backup allows users who have enabled USB debugging to copy application data off of the device. Once backed up, all application data can be read by the user. adb restore allows creation of application data from a source specified by the user. Following a restore, applications should not assume that the data, file permissions, and directory permissions were created by the application itself.

Setting allowBackup="false" opts an application out of both backup and restore.

To fix this warning, decide whether your application should support backup, and explicitly set android:allowBackup=(true|false)".

If not set to false, and if targeting API 23 or later, lint will also warn that you should set android:fullBackupContent to configure auto backup.

More info:

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "AllowBackup" as explained in the Suppressing Warnings and Errors section.

AllowBackup Security Warning Priority 3/10

Using wakeLock without timeout

../../src/org/muctec/smartfritz/jHttpClient.java:1193: Provide a timeout when requesting a wakelock with PowerManager.Wakelock.acquire(long timeout). This will ensure the OS will cleanup any wakelocks that last longer than you intend, and will save your user's battery.

 1190          super.onPreExecute();
 1191          PowerManager pm = (PowerManager) context.getSystemService(Context.POWER_SERVICE);
 1192          mWakeLock = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, getClass().getName());
 1193          mWakeLock.acquire();                                                                    
 1194      }
 1195 
 1196      @Override

Wakelocks have two acquire methods: one with a timeout, and one without. You should generally always use the one with a timeout. A typical timeout is 10 minutes. If the task takes longer than it is critical that it happens (i.e. can't use JobScheduler) then maybe they should consider a foreground service instead (which is a stronger run guarantee and lets the user know something long/important is happening).
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "WakelockTimeout" as explained in the Suppressing Warnings and Errors section.

WakelockTimeout Performance Warning Priority 9/10

Obsolete SDK_INT Version Check

../../res/values-v11: This folder configuration (v11) is unnecessary; minSdkVersion is 14. Merge all the resources in this folder into values.
../../res/values-v14: This folder configuration (v14) is unnecessary; minSdkVersion is 14. Merge all the resources in this folder into values.

This check flags version checks that are not necessary, because the minSdkVersion (or surrounding known API level) is already at least as high as the version checked for.

Similarly, it also looks for resources in -vNN folders, such as values-v14 where the version qualifier is less than or equal to the minSdkVersion, where the contents should be merged into the best folder.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "ObsoleteSdkInt" as explained in the Suppressing Warnings and Errors section.

ObsoleteSdkInt Performance Warning Priority 6/10

Static Field Leaks

../../src/org/muctec/smartfritz/jHttpClient.java:990: This AsyncTask class should be static or leaks might occur (org.muctec.smartfritz.jHttpClient.AsyncHttpClientPostNameValueData)

  987        Result: This is the type that doInBackground returns.
  988      */
  989 
  990     class AsyncHttpClientPostNameValueData extends AsyncTask<String, Integer, String> {             
  991 
  992         @Override
  993         protected String doInBackground(String... stringUrl) {

../../src/org/muctec/smartfritz/jHttpClient.java:1075: This AsyncTask class should be static or leaks might occur (org.muctec.smartfritz.jHttpClient.AsyncHttpClientGet)

 1072         }
 1073     }
 1074 
 1075     class AsyncHttpClientGet extends AsyncTask<String, Integer, String> {                           
 1076 
 1077         @Override
 1078         protected String doInBackground(String... stringUrl) {

../../src/org/muctec/smartfritz/jHttpClient.java:1178: This AsyncTask class should be static or leaks might occur (org.muctec.smartfritz.jHttpClient.UploadTask)

 1175     // </html>
 1176     //
 1177 
 1178     private class UploadTask extends AsyncTask<String, Integer, String> {                           
 1179 
 1180         private Context context;
 1181         private PowerManager.WakeLock mWakeLock;

A static field will leak contexts.

Non-static inner classes have an implicit reference to their outer class. If that outer class is for example a Fragment or Activity, then this reference means that the long-running handler/loader/task will hold a reference to the activity which prevents it from getting garbage collected.

Similarly, direct field references to activities and fragments from these longer running instances can cause leaks.

ViewModel classes should never point to Views or non-application Contexts.
To suppress this error, use the issue id "StaticFieldLeak" as explained in the Suppressing Warnings and Errors section.

StaticFieldLeak Performance Warning Priority 6/10

Unused resources

../../res/layout/activity_app.xml:1: The resource R.layout.activity_app appears to be unused

  1 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"                          
  2     xmlns:tools="http://schemas.android.com/tools"
  3     android:layout_width="match_parent"
  4     android:layout_height="match_parent"

../../res/drawable/bg_material.png:

The resource R.drawable.bg_material appears to be unused
../../res/values/colors.xml:7: The resource R.color.secondary_text appears to be unused

  4   <color name="primary_light">#C5CAE9</color>
  5   <color name="accent">#03A9F4</color>
  6   <color name="primary_text">#212121</color>
  7   <color name="secondary_text">#727272</color>                                                      
  8   <color name="icons">#FFFFFF</color>
  9   <color name="divider">#B6B6B6</color>
 10 </resources>

../../res/values/colors.xml:8: The resource R.color.icons appears to be unused

  5   <color name="accent">#03A9F4</color>
  6   <color name="primary_text">#212121</color>
  7   <color name="secondary_text">#727272</color>
  8   <color name="icons">#FFFFFF</color>                                                               
  9   <color name="divider">#B6B6B6</color>
 10 </resources>

../../res/values/colors.xml:9: The resource R.color.divider appears to be unused

  6   <color name="primary_text">#212121</color>
  7   <color name="secondary_text">#727272</color>
  8   <color name="icons">#FFFFFF</color>
  9   <color name="divider">#B6B6B6</color>                                                             
 10 </resources>

../../res/drawable-hdpi/ic_call_icon.png:

The resource R.drawable.ic_call_icon appears to be unused
../../res/drawable-hdpi/ic_cervantes.png:

The resource R.drawable.ic_cervantes appears to be unused
../../res/drawable-hdpi/ic_chevron_left_black_48dp.png: The resource R.drawable.ic_chevron_left_black_48dp appears to be unused

hdpi	xhdpi

../../res/drawable-hdpi/ic_chevron_right_black_48dp.png: The resource R.drawable.ic_chevron_right_black_48dp appears to be unused

hdpi	xhdpi

../../res/drawable-hdpi/ic_don_quixote.png:

The resource R.drawable.ic_don_quixote appears to be unused
../../res/drawable-hdpi/ic_fritzbox.png:

The resource R.drawable.ic_fritzbox appears to be unused
../../res/drawable-hdpi/ic_fritzbox_icon.png:

The resource R.drawable.ic_fritzbox_icon appears to be unused
../../res/drawable-hdpi/ic_lance.png:

The resource R.drawable.ic_lance appears to be unused
../../res/drawable-hdpi/ic_log_icon.png:

The resource R.drawable.ic_log_icon appears to be unused
../../res/drawable-hdpi/ic_menu_white_36dp.png: The resource R.drawable.ic_menu_white_36dp appears to be unused

hdpi	xhdpi

../../res/drawable-hdpi/ic_scene_1.jpg:

The resource R.drawable.ic_scene_1 appears to be unused
../../res/drawable-hdpi/ic_scene_2.png:

The resource R.drawable.ic_scene_2 appears to be unused
../../res/drawable-hdpi/ic_scene_3.jpg:

The resource R.drawable.ic_scene_3 appears to be unused
../../res/drawable-hdpi/ic_settings_icon.png:

The resource R.drawable.ic_settings_icon appears to be unused
../../res/drawable-hdpi/ic_state_icon.png:

The resource R.drawable.ic_state_icon appears to be unused
../../res/drawable-hdpi/ic_windmil.png:

The resource R.drawable.ic_windmil appears to be unused
../../res/values/styles.xml:7: The resource R.style.AppBaseTheme appears to be unused

  4         Base application theme, dependent on API level. This theme is replaced
  5         by AppBaseTheme from res/values-vXX/styles.xml on newer devices.
  6     -->
  7     <style name="AppBaseTheme" parent="android:Theme.Light">                                        
  8         <!--
  9             Theme customizations available in newer API levels can go in
 10             res/values-vXX/styles.xml, while customizations related to

UnusedResources Performance Warning Priority 3/10

Icon density-independent size validation

../../res/drawable-xxhdpi/ic_launcher.png: The image ic_launcher.png varies significantly in its density-independent (dip) size across the various density versions: drawable-hdpi/ic_launcher.png: 48x48 dp (72x72 px), drawable-ldpi/ic_launcher.png: 43x43 dp (32x32 px), drawable-mdpi/ic_launcher.png: 48x48 dp (48x48 px), drawable-xhdpi/ic_launcher.png: 36x36 dp (72x72 px), drawable-xxhdpi/ic_launcher.png: 24x24 dp (72x72 px)

ldpi	mdpi	hdpi	xhdpi	xxhdpi

Checks the all icons which are provided in multiple densities, all compute to roughly the same density-independent pixel (dip) size. This catches errors where images are either placed in the wrong folder, or icons are changed to new sizes but some folders are forgotten.
To suppress this error, use the issue id "IconDipSize" as explained in the Suppressing Warnings and Errors section.

IconDipSize Icons Usability Warning Priority 5/10

Identical bitmaps across various configurations

../../res/drawable-xxhdpi/ic_launcher.png: The ic_launcher.png icon has identical contents in the following configuration folders: drawable-hdpi, drawable-xhdpi, drawable-xxhdpi

hdpi	xhdpi	xxhdpi

If an icon is provided under different configuration parameters such as drawable-hdpi or -v11, they should typically be different. This detector catches cases where the same icon is provided in different configuration folder which is usually not intentional.
To suppress this error, use the issue id "IconDuplicatesConfig" as explained in the Suppressing Warnings and Errors section.

IconDuplicatesConfig Icons Usability Warning Priority 5/10

Image defined in density-independent drawable folder

../../res/drawable/bg_material.png:

Found bitmap drawable res/drawable/bg_material.png in densityless folder

The res/drawable folder is intended for density-independent graphics such as shapes defined in XML. For bitmaps, move it to drawable-mdpi and consider providing higher and lower resolution versions in drawable-ldpi, drawable-hdpi and drawable-xhdpi. If the icon really is density independent (for example a solid color) you can place it in drawable-nodpi.

More info: http://developer.android.com/guide/practices/screens_support.html

To suppress this error, use the issue id "IconLocation" as explained in the Suppressing Warnings and Errors section.

IconLocation Icons Usability Warning Priority 5/10

Icon densities validation

../../res/drawable-mdpi: Missing the following drawables in drawable-mdpi: ic_call_icon.png, ic_cervantes.png, ic_chevron_left_black_48dp.png, ic_chevron_right_black_48dp.png, ic_don_quixote.png... (11 more)
../../res/drawable-xhdpi: Missing the following drawables in drawable-xhdpi: ic_call_icon.png, ic_cervantes.png, ic_don_quixote.png, ic_fritzbox.png, ic_fritzbox_icon.png... (8 more)
../../res/drawable-xxhdpi: Missing the following drawables in drawable-xxhdpi: ic_call_icon.png, ic_cervantes.png, ic_chevron_left_black_48dp.png, ic_chevron_right_black_48dp.png, ic_don_quixote.png... (11 more)

Icons will look best if a custom version is provided for each of the major screen density classes (low, medium, high, extra high). This lint check identifies icons which do not have complete coverage across the densities.

Low density is not really used much anymore, so this check ignores the ldpi density. To force lint to include it, set the environment variable ANDROID_LINT_INCLUDE_LDPI=true. For more information on current density usage, see http://developer.android.com/resources/dashboard/screens.html

More info: http://developer.android.com/guide/practices/screens_support.html

To suppress this error, use the issue id "IconDensities" as explained in the Suppressing Warnings and Errors section.

IconDensities Icons Usability Warning Priority 4/10

Missing support for Firebase App Indexing

../../AndroidManifest.xml:39: App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details.

 36   <uses-feature android:name="android.hardware.sensor.stepcounter" android:required="false"/>
 37   <uses-feature android:name="android.hardware.sensor.stepdetector" android:required="false"/>
 38   <supports-screens android:smallScreens="true" android:normalScreens="true" android:largeScreens="true" android:anyDensity="true"/>
 39   <application android:allowBackup="true" android:icon="@drawable/ic_launcher" android:label="@string/app_name" android:theme="@style/AppTheme" android:networkSecurityConfig="@xml/network_security_config">
 40     <activity android:name="org.muctec.smartfritz.App" android:label="@string/app_name" android:configChanges="orientation|keyboardHidden|screenSize|screenLayout|fontScale" android:launchMode="standard" android:enabled="true">
 41       <intent-filter>
 42         <action android:name="android.intent.action.MAIN"/>

GoogleAppIndexingWarning Usability Warning Priority 5/10

Missing View constructors for XML inflation

../../src/org/muctec/smartfritz/jButton.java:24: Custom view jButton is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  21 import android.view.ViewGroup;
  22 import android.widget.Button;
  23 
  24 public class jButton extends Button {                                                               
  25 
  26     private Controls controls = null;   // Control Class for Event
  27     private jCommons LAMWCommon;

../../src/org/muctec/smartfritz/jCheckBox.java:13: Custom view jCheckBox is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  10 import android.widget.CheckBox;
  11 import android.view.Gravity;
  12 
  13 public class jCheckBox extends CheckBox {                                                           
  14     //Java-Pascal Interface
  15     private long             PasObj   = 0;      // Pascal Obj
  16     private Controls        controls = null;   // Control Class for Event

../../src/org/muctec/smartfritz/jEditText.java:42: Custom view jEditText is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  39 
  40 //Reviewed by TR3E on 08/20/2019
  41 
  42 public class jEditText extends EditText {                                                           
  43     //Pascal Interface
  44     //private long           PasObj   = 0;      // Pascal Obj
  45     private Controls      controls = null;   // Control Class for Event

../../src/org/muctec/smartfritz/jExpandableListView.java:411: Custom view jExpandableListView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

 408 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
 409 /*jVisualControl LAMW template*/
 410  
 411 public class jExpandableListView extends ExpandableListView /*dummy*/ { //please, fix what GUI object will be extended!
 412 
 413    private long pascalObj = 0;        // Pascal Object
 414    private Controls controls  = null; //Java/Pascal [events] Interface ...

../../src/org/muctec/smartfritz/jPanel.java:23: Custom view jPanel is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  20 import android.view.animation.TranslateAnimation;
  21 import android.widget.RelativeLayout;
  22 
  23 public class jPanel extends RelativeLayout {                                                        
  24     //Java-Pascal Interface
  25     private long             PasObj   = 0;      // Pascal Obj
  26     private Controls        controls = null;   // Control Class for Event

../../src/org/muctec/smartfritz/jSwitchButton.java:17: Custom view jSwitchButton is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  14 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  15 /*jVisualControl template*/
  16 
  17 public class jSwitchButton extends Switch /*API 14*/ { //please, fix what GUI object will be extended!
  18 
  19    private long       pascalObj = 0;    // Pascal Object
  20    private Controls   controls  = null; // Control Class for events

../../src/org/muctec/smartfritz/jTextView.java:37: Custom view jTextView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  34 import android.view.Gravity;
  35 import android.widget.TextView;
  36 
  37 public class jTextView extends TextView {                                                           
  38     //Java-Pascal Interface
  39     private Controls        controls = null;   // Control Class for Event
  40     private jCommons LAMWCommon;

../../src/org/muctec/smartfritz/jsBottomNavigationView.java:20: Custom view jsBottomNavigationView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  17 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  18 /*jVisualControl LAMW template*/
  19  
  20 public class jsBottomNavigationView extends BottomNavigationView /*dummy*/ { //please, fix what GUI object will be extended!
  21 
  22    private long pascalObj = 0;        // Pascal Object
  23    private Controls controls  = null; //Java/Pascal [events] Interface ...

../../src/org/muctec/smartfritz/jsDrawerLayout.java:18: Custom view jsDrawerLayout is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  15 /*Draft java code by "Lazarus Android Module Wizard" [12/16/2017 0:26:36]*/
  16 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  17 /*jVisualControl LAMW template*/
  18 public class jsDrawerLayout extends DrawerLayout /*dummy*/ { //please, fix what GUI object will be extended!
  19 
  20    private long pascalObj = 0;        // Pascal Object
  21    private Controls controls  = null; //Java/Pascal [events] Interface ...

../../src/org/muctec/smartfritz/jsFloatingButton.java:16: Custom view jsFloatingButton is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  13 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  14 /*jVisualControl LAMW template*/
  15  
  16 public class jsFloatingButton extends FloatingActionButton /*dummy*/ { //please, fix what GUI object will be extended!
  17 
  18    private long pascalObj = 0;        // Pascal Object
  19    private Controls controls  = null; //Java/Pascal [events] Interface ...

../../src/org/muctec/smartfritz/jsNavigationView.java:36: Custom view jsNavigationView is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  33 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  34 /*jVisualControl LAMW template*/
  35  
  36 public class jsNavigationView extends NavigationView /*dummy*/ { //please, fix what GUI object will be extended!
  37 
  38    private long pascalObj = 0;        // Pascal Object
  39    private Controls controls  = null; //Java/Pascal [events] Interface ...

../../src/org/muctec/smartfritz/jsToolbar.java:20: Custom view jsToolbar is missing constructor used by tools: (Context) or (Context,AttributeSet) or (Context,AttributeSet,int)

  17 /*https://github.com/jmpessoa/lazandroidmodulewizard*/
  18 /*jVisualControl LAMW template*/
  19  
  20 public class jsToolbar extends Toolbar /*dummy*/ { //please, fix what GUI object will be extended!  
  21 
  22    private long pascalObj = 0;        // Pascal Object
  23    private Controls controls  = null; //Java/Pascal [events] Interface ...

Some layout tools (such as the Android layout editor) need to find a constructor with one of the following signatures:
* View(Context context)
* View(Context context, AttributeSet attrs)
* View(Context context, AttributeSet attrs, int defStyle)

If your custom view needs to perform initialization which does not apply when used in a layout editor, you can surround the given code with a check to see if View#isInEditMode() is false, since that method will return false at runtime but true within a user interface editor.
To suppress this error, use the issue id "ViewConstructor" as explained in the Suppressing Warnings and Errors section.

ViewConstructor Usability Warning Priority 3/10

Accessibility in Custom Views

../../src/org/muctec/smartfritz/jPanel.java:135: Custom view jPanel overrides onTouchEvent but not performClick

 132     }
 133 
 134     @Override
 135     public boolean onTouchEvent(MotionEvent event) {                                                   
 136         return super.onTouchEvent(event);
 137     }

If a View that overrides onTouchEvent or uses an OnTouchListener does not also implement performClick and call it when clicks are detected, the View may not handle accessibility actions properly. Logic handling the click actions should ideally be placed in View#performClick as some accessibility services invoke performClick when a click action should occur.
To suppress this error, use the issue id "ClickableViewAccessibility" as explained in the Suppressing Warnings and Errors section.

ClickableViewAccessibility Accessibility Warning Priority 6/10

Disabled Checks

One or more issues were not run by lint, either because the check is not enabled by default, or because it was disabled with a command line flag or via one or more lint.xml configuration files in the project directories.

AppLinksAutoVerifyError

Disabled By: Default

Ensures that app links are correctly set and associated with website.

More info: https://g.co/appindexing/applinks

To suppress this error, use the issue id "AppLinksAutoVerifyError" as explained in the Suppressing Warnings and Errors section.

AppLinksAutoVerifyWarning

Disabled By: Default

Ensures that app links are correctly set and associated with website.

More info: https://g.co/appindexing/applinks

To suppress this error, use the issue id "AppLinksAutoVerifyWarning" as explained in the Suppressing Warnings and Errors section.

BackButton

Disabled By: Default

According to the Android Design Guide,

"Other platforms use an explicit back button with label to allow the user to navigate up the application's hierarchy. Instead, Android uses the main action bar's app icon for hierarchical navigation and the navigation bar's back button for temporal navigation."
This check is not very sophisticated (it just looks for buttons with the label "Back"), so it is disabled by default to not trigger on common scenarios like pairs of Back/Next buttons to paginate through screens.

More info: http://developer.android.com/design/patterns/pure-android.html

To suppress this error, use the issue id "BackButton" as explained in the Suppressing Warnings and Errors section.

ConvertToWebp

Disabled By: Default

The WebP format is typically more compact than PNG and JPEG. As of Android 4.2.1 it supports transparency and lossless conversion as well. Note that there is a quickfix in the IDE which lets you perform conversion.

Launcher icons must be in the PNG format.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "ConvertToWebp" as explained in the Suppressing Warnings and Errors section.

DalvikOverride

Disabled By: Default

The Dalvik virtual machine will treat a package private method in one class as overriding a package private method in its super class, even if they are in separate packages.

If you really did intend for this method to override the other, make the method protected instead.

If you did not intend the override, consider making the method private, or changing its name or signature.

Note that this check is disabled be default, because ART (the successor to Dalvik) no longer has this behavior.
To suppress this error, use the issue id "DalvikOverride" as explained in the Suppressing Warnings and Errors section.

DuplicateStrings

Disabled By: Default

Duplicate strings can make applications larger unnecessarily.

This lint check looks for duplicate strings, including differences for strings where the only difference is in capitalization. Title casing and all uppercase can all be adjusted in the layout or in code.

More info: https://developer.android.com/reference/android/widget/TextView.html#attr_android:inputType

To suppress this error, use the issue id "DuplicateStrings" as explained in the Suppressing Warnings and Errors section.

EasterEgg

Disabled By: Default

An "easter egg" is code deliberately hidden in the code, both from potential users and even from other developers. This lint check looks for code which looks like it may be hidden from sight.
To suppress this error, use the issue id "EasterEgg" as explained in the Suppressing Warnings and Errors section.

FieldGetter

Disabled By: Default

Accessing a field within the class that defines a getter for that field is at least 3 times faster than calling the getter. For simple getters that do nothing other than return the field, you might want to just reference the local field directly instead.

NOTE: As of Android 2.3 (Gingerbread), this optimization is performed automatically by Dalvik, so there is no need to change your code; this is only relevant if you are targeting older versions of Android.

More info: http://developer.android.com/guide/practices/design/performance.html#internal_get_set

To suppress this error, use the issue id "FieldGetter" as explained in the Suppressing Warnings and Errors section.

GoogleAppIndexingApiWarning

Disabled By: Default

Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search.

More info: https://g.co/AppIndexing/AndroidStudio

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "GoogleAppIndexingApiWarning" as explained in the Suppressing Warnings and Errors section.

IconExpectedSize

Disabled By: Default

There are predefined sizes (for each density) for launcher icons. You should follow these conventions to make sure your icons fit in with the overall look of the platform.

More info: http://developer.android.com/design/style/iconography.html

To suppress this error, use the issue id "IconExpectedSize" as explained in the Suppressing Warnings and Errors section.

ImplicitSamInstance

Disabled By: Default

Kotlin's support for SAM (single accessor method) interfaces lets you pass a lambda to the interface. This will create a new instance on the fly even though there is no explicit constructor call. If you pass one of these lambdas or method references into a method which (for example) stores or compares the object identity, unexpected results may happen.
To suppress this error, use the issue id "ImplicitSamInstance" as explained in the Suppressing Warnings and Errors section.

KotlinPropertyAccess

Disabled By: Default

For a method to be represented as a property in Kotlin, strict “bean”-style prefixing must be used.

Accessor methods require a ‘get’ prefix or for boolean-returning methods an ‘is’ prefix can be used.

More info: https://android.github.io/kotlin-guides/interop.html#property-prefixes

To suppress this error, use the issue id "KotlinPropertyAccess" as explained in the Suppressing Warnings and Errors section.

LambdaLast

Disabled By: Default

To improve calling this code from Kotlin,
parameter types eligible for SAM conversion should be last.

More info: https://android.github.io/kotlin-guides/interop.html#lambda-parameters-last

To suppress this error, use the issue id "LambdaLast" as explained in the Suppressing Warnings and Errors section.

LogConditional

Disabled By: Default

The BuildConfig class (available in Tools 17) provides a constant, "DEBUG", which indicates whether the code is being built in release mode or in debug mode. In release mode, you typically want to strip out all the logging calls. Since the compiler will automatically remove all code which is inside a "if (false)" check, surrounding your logging calls with a check for BuildConfig.DEBUG is a good idea.

If you really intend for the logging to be present in release mode, you can suppress this warning with a @SuppressLint annotation for the intentional logging calls.
To suppress this error, use the issue id "LogConditional" as explained in the Suppressing Warnings and Errors section.

MangledCRLF

Disabled By: Default

On Windows, line endings are typically recorded as carriage return plus newline: \r\n.

This detector looks for invalid line endings with repeated carriage return characters (without newlines). Previous versions of the ADT plugin could accidentally introduce these into the file, and when editing the file, the editor could produce confusing visual artifacts.

More info: https://bugs.eclipse.org/bugs/show_bug.cgi?id=375421

To suppress this error, use the issue id "MangledCRLF" as explained in the Suppressing Warnings and Errors section.

MinSdkTooLow

Disabled By: Default

The value of the minSdkVersion property is too low and can be incremented without noticeably reducing the number of supported devices.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "MinSdkTooLow" as explained in the Suppressing Warnings and Errors section.

MissingRegistered

Disabled By: Default

If a class is referenced in the manifest or in a layout file, it must also exist in the project (or in one of the libraries included by the project. This check helps uncover typos in registration names, or attempts to rename or move classes without updating the manifest file properly.

More info: http://developer.android.com/guide/topics/manifest/manifest-intro.html

To suppress this error, use the issue id "MissingRegistered" as explained in the Suppressing Warnings and Errors section.

NegativeMargin

Disabled By: Default

Margin values should be positive. Negative values are generally a sign that you are making assumptions about views surrounding the current one, or may be tempted to turn off child clipping to allow a view to escape its parent. Turning off child clipping to do this not only leads to poor graphical performance, it also results in wrong touch event handling since touch events are based strictly on a chain of parent-rect hit tests. Finally, making assumptions about the size of strings can lead to localization problems.
To suppress this error, use the issue id "NegativeMargin" as explained in the Suppressing Warnings and Errors section.

NewerVersionAvailable

Disabled By: Default

This detector checks with a central repository to see if there are newer versions available for the dependencies used by this project. This is similar to the GradleDependency check, which checks for newer versions available in the Android SDK tools and libraries, but this works with any MavenCentral dependency, and connects to the library every time, which makes it more flexible but also much slower.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "NewerVersionAvailable" as explained in the Suppressing Warnings and Errors section.

NoHardKeywords

Disabled By: Default

Do not use Kotlin’s hard keywords as the name of methods or fields.
These require the use of backticks to escape when calling from Kotlin.
Soft keywords, modifier keywords, and special identifiers are allowed.

For example, Mockito’s when function requires backticks when used from Kotlin:

val callable = Mockito.mock(Callable::class.java)
Mockito.`when`(callable.call()).thenReturn(/* … */)

More info: https://android.github.io/kotlin-guides/interop.html#no-hard-keywords

To suppress this error, use the issue id "NoHardKeywords" as explained in the Suppressing Warnings and Errors section.

PermissionImpliesUnsupportedChromeOsHardware

Disabled By: Default

The <uses-permission> element should not require a permission that implies an unsupported Chrome OS hardware feature. Google Play assumes that certain hardware related permissions indicate that the underlying hardware features are required by default. To fix the issue, consider declaring the corresponding uses-feature element with required="false" attribute.

More info: https://developer.android.com/topic/arc/manifest.html#implied-features

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "PermissionImpliesUnsupportedChromeOsHardware" as explained in the Suppressing Warnings and Errors section.

Registered

Disabled By: Default

Activities, services and content providers should be registered in the AndroidManifest.xml file using <activity>, <service> and <provider> tags.

If your activity is simply a parent class intended to be subclassed by other "real" activities, make it an abstract class.

More info: http://developer.android.com/guide/topics/manifest/manifest-intro.html

To suppress this error, use the issue id "Registered" as explained in the Suppressing Warnings and Errors section.

RequiredSize

Disabled By: Default

All views must specify an explicit layout_width and layout_height attribute. There is a runtime check for this, so if you fail to specify a size, an exception is thrown at runtime.

It's possible to specify these widths via styles as well. GridLayout, as a special case, does not require you to specify a size.
To suppress this error, use the issue id "RequiredSize" as explained in the Suppressing Warnings and Errors section.

SelectableText

Disabled By: Default

If a <TextView> is used to display data, the user might want to copy that data and paste it elsewhere. To allow this, the <TextView> should specify android:textIsSelectable="true".

This lint check looks for TextViews which are likely to be displaying data: views whose text is set dynamically. This value will be ignored on platforms older than API 11, so it is okay to set it regardless of your minSdkVersion.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "SelectableText" as explained in the Suppressing Warnings and Errors section.

StopShip

Disabled By: Default

Using the comment // STOPSHIP can be used to flag code that is incomplete but checked in. This comment marker can be used to indicate that the code should not be shipped until the issue is addressed, and lint will look for these. In Gradle projects, this is only checked for non-debug (release) builds.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "StopShip" as explained in the Suppressing Warnings and Errors section.

SyntheticAccessor

Disabled By: Default

A private inner class which is accessed from the outer class will force the compiler to insert a synthetic accessor; this means that you are causing extra overhead. This is not important in small projects, but is important for large apps running up against the 64K method handle limit, and especially for libraries where you want to make sure your library is as small as possible for the cases where your library is used in an app running up against the 64K limit.
To suppress this error, use the issue id "SyntheticAccessor" as explained in the Suppressing Warnings and Errors section.

TypographyQuotes

Disabled By: Default

Straight single quotes and double quotes, when used as a pair, can be replaced by "curvy quotes" (or directional quotes). This can make the text more readable.

Note that you should never use grave accents and apostrophes to quote, `like this'.

(Also note that you should not use curvy quotes for code fragments.)

More info: http://en.wikipedia.org/wiki/Quotation_mark

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "TypographyQuotes" as explained in the Suppressing Warnings and Errors section.

UnknownNullness

Disabled By: Default

To improve referencing this code from Kotlin, consider adding
explicit nullness information here with either @NonNull or @Nullable.

You can set the environment variable
ANDROID_LINT_NULLNESS_IGNORE_DEPRECATED=true
if you want lint to ignore classes and members that have been annotated with
@Deprecated.

More info: https://android.github.io/kotlin-guides/interop.html#nullability-annotations

To suppress this error, use the issue id "UnknownNullness" as explained in the Suppressing Warnings and Errors section.

UnpackedNativeCode

Disabled By: Default

This app loads native libraries using System.loadLibrary().

Consider adding android:extractNativeLibs="false" to the <application> tag in AndroidManifest.xml. Starting with Android 6.0, this will make installation faster, the app will take up less space on the device and updates will have smaller download sizes.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnpackedNativeCode" as explained in the Suppressing Warnings and Errors section.

UnsupportedChromeOsHardware

Disabled By: Default

The <uses-feature> element should not require this unsupported Chrome OS hardware feature. Any uses-feature not explicitly marked with required="false" is necessary on the device to be installed on. Ensure that any features that might prevent it from being installed on a Chrome OS device are reviewed and marked as not required in the manifest.

More info: https://developer.android.com/topic/arc/manifest.html#incompat-entries

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnsupportedChromeOsHardware" as explained in the Suppressing Warnings and Errors section.

UnusedIds

Disabled By: Default

This resource id definition appears not to be needed since it is not referenced from anywhere. Having id definitions, even if unused, is not necessarily a bad idea since they make working on layouts and menus easier, so there is not a strong reason to delete these.

The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.

You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests=true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests=true.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnusedIds" as explained in the Suppressing Warnings and Errors section.

WrongThreadInterprocedural

Disabled By: Default

Searches for interprocedural call paths that violate thread annotations in the program. Tracks the flow of instantiated types and lambda expressions to increase accuracy across method boundaries.

More info: https://developer.android.com/guide/components/processes-and-threads.html#Threads

To suppress this error, use the issue id "WrongThreadInterprocedural" as explained in the Suppressing Warnings and Errors section.

Suppressing Warnings and Errors

Lint errors can be suppressed in a variety of ways:

1. With a @SuppressLint annotation in the Java code
2. With a tools:ignore attribute in the XML file
3. With a //noinspection comment in the source code
4. With ignore flags specified in the build.gradle file, as explained below
5. With a lint.xml configuration file in the project
6. With a lint.xml configuration file passed to lint via the --config flag
7. With the --ignore flag passed to lint.

To suppress a lint warning with an annotation, add a @SuppressLint("id") annotation on the class, method or variable declaration closest to the warning instance you want to disable. The id can be one or more issue id's, such as "UnusedResources" or {"UnusedResources","UnusedIds"}, or it can be "all" to suppress all lint warnings in the given scope.

To suppress a lint warning with a comment, add a //noinspection id comment on the line before the statement with the error.

To suppress a lint warning in an XML file, add a tools:ignore="id" attribute on the element containing the error, or one of its surrounding elements. You also need to define the namespace for the tools prefix on the root element in your document, next to the xmlns:android declaration:
xmlns:tools="http://schemas.android.com/tools"

To suppress a lint warning in a build.gradle file, add a section like this:

android {
    lintOptions {
        disable 'TypographyFractions','TypographyQuotes'
    }
}

Here we specify a comma separated list of issue id's after the disable command. You can also use warning or error instead of disable to change the severity of issues.

To suppress lint warnings with a configuration XML file, create a file named lint.xml and place it at the root directory of the module in which it applies.

The format of the lint.xml file is something like the following:

<?xml version="1.0" encoding="UTF-8"?>
<lint>
    
    <issue id="all">
        <ignore path="*/test/*" />
    </issue>

    
    <issue id="IconMissingDensityFolder" severity="ignore" />

    
    <issue id="ObsoleteLayoutParam">
        <ignore path="res/layout/activation.xml" />
        <ignore path="res/layout-xlarge/activation.xml" />
        <ignore regexp="(foo|bar).java" />
    </issue>

    
    <issue id="UselessLeaf">
        <ignore path="res/layout/main.xml" />
    </issue>

    
    <issue id="HardcodedText" severity="error" />
</lint>

To suppress lint checks from the command line, pass the --ignore flag with a comma separated list of ids to be suppressed, such as:
$ lint --ignore UnusedResources,UselessLeaf /my/project/path

For more information, see http://g.co/androidstudio/suppressing-lint-warnings